Use a trie to speed up index construction #887
Draft
+229
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #507
Fixes #795
Awaiting #904 before I continue working on this
In
regex.py
Outlines compiles an index of legal tokens for each state of the FSM (state_scan_tokens
)On the
main
branch we use this naive approachCalling
_walk_fsm
once for everynum_tokens * num_states_per_token
is inefficient and the current bottleneck in index construction.We can improve this by using a Trie (implementation details to come)