-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a few tests for --compile --target #10523
base: main
Are you sure you want to change the base?
Conversation
const name_value = callframe.arguments(1).ptr[0]; | ||
const input = name_value.toSlice(global, bun.default_allocator); | ||
defer input.deinit(); | ||
const target = CompileTarget.from(input.slice()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol doesnt this function exit the program on failure.
would be cool if we could test the parser. its fine of course.
var i = 0; | ||
var list = []; | ||
while (i < text.length) { | ||
let errorLineI = text.indexOf(prefix, i); | ||
if (errorLineI === -1) { | ||
// Sometimes, our errors start with the error name itself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah i understand alot more now. thanks for the comment
What does this PR do?
Add a few tests for --compile --target
How did you verify your code works?
Tests