Fix sloppily written test #10976
Open
Fix sloppily written test #10976
+34
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarred-Sumner
force-pushed
the
jarred/ci-test
branch
from
2b68b72
to
658c469
Compare
nektro
reviewed
May 10, 2024
Comment on lines
-7
to
+6
| it.skipIf(!process.env.TEST_INFO_STRIPE)("should be able to query a charge", async () => { | ||
| it.skipIf(!isBunCI && !process.env.TEST_INFO_STRIPE)("should be able to query a charge", async () => { |
There was a problem hiding this comment.
what issues did you have running it locally?
| let err = await new Response(stderr).text(); | ||
| expect(err).not.toContain("panic:"); | ||
| expect(err).not.toContain("error:"); | ||
| expect(err).not.toContain("warn:"); | ||
| let out = await new Response(stdout).text(); | ||
| expect(await exited).toBe(0); |
There was a problem hiding this comment.
it was done the other way so that you can see what the error was when it failed and nothing when it succeeds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix sloppily written test (cc @nektro):
"stripe"into the bun repository instead of the temporary test folderbun installString.rawusage is unnecessarybun:testThis also:
bun installin/package.jsonortest/package.jsonfrom inside a test fail so that we don't runbun installin the wrong directory again in a testHow did you verify your code works?
Ran the stripe test locally