fix: Sonarcloud memleak fixes

[airween]

This pull request fixes two memory leaks, reported by SonarCloud.

• test/regression/regression.cc
• tools/rules-check/rules-check.cc

None of them modified the library itself.

[airween]

This block makes no sense.

The variable is initialized as an empty string in line 49 in each cycle.

49.      std::string argFull("");

therefore the condition's left side (argFull.empty()) is always true which means the condition itself

54.        if (argFull.empty() == false) {

is always false. Moreover, in the two branches in that block after the append() the code jumps to the next label, where the cycle ends...

So I'm going to remove it.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[MirkoDziadzka]

Looks a lot simpler, thanks.