Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted redundant code in 'ModSecurity::serverLog(...)'. #3116

Open
wants to merge 1 commit into
base: v3/master
Choose a base branch
from

Conversation

gberkes
Copy link

@gberkes gberkes commented Mar 28, 2024

The complete 'if (...) {...}' construction can be removed because the same code is executed immediately after the 'if (...) {...}' construction. When the condition evaluates to true, the same data is logged twice.

Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@airween airween added the 3.x Related to ModSecurity version 3.x label Mar 29, 2024
@airween airween self-assigned this Mar 29, 2024
@airween
Copy link
Member

airween commented Mar 29, 2024

For the record: this PR solves this SonarCloud issue.

Copy link
Member

@airween airween left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Related to ModSecurity version 3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants