Support versions of ffmpeg greater than 5 #3476
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #12248 ↗︎
Details:
Review all test suite changes for PR #3476 ↗︎ |
|||||||||||||||
gabek
changed the title
|
Note: Ignore the conflicts, the web project was built for this PR just for testing. It will be reverted before it gets merged in. |
|
This pull request has not had any activity in 30 days. Since things move fast it's best to get PRs merged in. If this PR addresses a previously filed issue that needs to be resolved please work to get it merged in, or allow somebody else to work on a fix. This PR will be closed if no further activity occurs. Thank you for your contributions! |
|
Meer |
Could you add detail to your comment? |
2 failed tests on run #16078 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Online readwrite chat embed > Show change name modal |
Screenshots
Video
|
|
| Online readwrite chat embed > Close name change modal |
Screenshots
Video
|
|
Review all test suite changes for PR #3476 ↗︎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits out
vaapicodec into two completely different options.Vaapi (Legacy)is what has always existed in Owncast, and supports ffmpeg versions older than 5.Vaapiis the new, up-to-date support for Vaapi and requires support for ffmpeg v5 and above.When running this code it will migrate you from using
vaapitoVaapi (Legacy), making the assumption if you were using vaapi before you were also using an older version of ffmpeg. If you need to change it to the new version, you must manually make that change.