增加SQL解析缓存，以提升性能sql parse cache #777
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
qxo
commented
Nov 3, 2023
qxo
commented
|
jsqlparser奇葩的地方是几乎每个版本都不兼容... 刚发布的6.0.0，如果4.7能解决问题，后续先考虑升级做兼容。 |
qxo
force-pushed
the
feat-sql-parse-cache
branch
3 times, most recently
from
7832fea
to
9f812de
Compare
qxo
changed the title
据我分析 jsqlparser 4.7 还是一样的问题，一样的慢 我重新提交一下了：修复排序时缓存SQL的bug |
|
项目做性能测试时压出问题来了，也是这个原因导致的。不知道这个问题有没有处理计划？ |
|
当前PR暂时不要做后续处理了，会先考虑和4.7做兼容（已经接近完成）。 |
|
新建了 https://github.com/pagehelper/pagehelper-sqlparser 模块，可以考虑在这个模块增加支持缓存的实现。 |
qxo
force-pushed
the
feat-sql-parse-cache
branch
from
9f812de
to
a200701
Compare
之前除SqlServerDialect外，其他Dialect之前没有sql解析缓存. 优化前项目中每次此plugin的SQL解析基本在7/8到几十毫秒之间，有时比sql本身数据库执行还慢时! 经分析这个慢原因是其依赖的jsqlparser本身解析就慢，且在4.5时有反向优化(采用线程池却没每次重新线程！) ``` jad net.sf.jsqlparser.parser.CCJSqlParserUtil parseStatement ``` 测试发现jsqlparser 4.7和pagehelper不兼容， 4.6 和4.5有同样的问题 增加SQL解析缓存后，重复访问的耗时基本0.5毫秒以下 *需要说明的这次重构目前只在mysql下测试，其他Dialect未经测试*
qxo
force-pushed
the
feat-sql-parse-cache
branch
from
a200701
to
4289054
Compare
没时间做代码结构调整, 有需要的请自取本PR吧:) 另外重新合并处理一下: 本PR已支持合并到当前最新master分支了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.