Improve non-arm64 detection #391
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just use strcmp |
squirtla
approved these changes
May 17, 2023
pixelomer
suggested changes
Jun 4, 2023
MonkeY-kr
approved these changes
Jun 6, 2023
Done.
Yeah, but palera1n doesn't currently support those devices anyway, and the DFU helper already didn't work on them before the arm64e check was broken, so it's not a big deal for now. |
asdfugil
force-pushed
the
main
branch
15 times, most recently
from
c9a405e
to
3df6791
Compare
asdfugil
force-pushed
the
main
branch
2 times, most recently
from
0306015
to
f2ac3ae
Compare
littleblack111
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes non-arm64 (e.g. arm64e) device detection in normal mode having been broken by a recent cleanup commit, unifies the warning messages, and adds a check for DFU mode as well.