-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for Run(ctx) interface #246
base: master
Are you sure you want to change the base?
Conversation
kind of busy these days, I will review this PR a few days later, thanks. |
README.md
Outdated
@@ -92,6 +92,16 @@ func demoFunc() { | |||
fmt.Println("Hello World!") | |||
} | |||
|
|||
type run struct { | |||
i int32 | |||
wg *sync.WaitGroup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it needs to gofmt here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hawkingrei
Yes, found this formatting issue.
Since it's a markdown file, I fixed it manually
name: Pull request
about: Add support for Run(ctx) interface
1. Are you opening this pull request for bug-fixs, optimizations or new feature?
yes
This is a pr for interface
Run(ctx)
support2. Please describe how these code changes achieve your intention.
NewPoolWithRunner
has been added.Can support
submit
any that implements the Runner interface3. Please link to the relevant issues (if any).
4. Which documentation changes (if any) need to be made/updated because of this PR?
ants_test.go
pool_run.go
worker_run.go
run.go
4. Checklist