Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the concept of extension point #360

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Relax the concept of extension point #360

wants to merge 5 commits into from

Conversation

decebals
Copy link
Member

@decebals decebals commented Dec 20, 2019

These changes will solve some of the issues discussed in #358.
It contains:

  • relax the type of Extension#points field (see Support any interface as an ExtensionPoint #289 (comment))
  • ExtensionAnnotationProcessor checks that an extension implements the ExtensionPoint marker interface only if the pf4j.checkExtensionPoint annotation option is present. By default the check is disabled

Copy link
Contributor

@dmitry-timofeev dmitry-timofeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however, I am not an expert in this code 👍

@decebals
Copy link
Member Author

Is there any interest in this functionality?

@dmitry-timofeev
Copy link
Contributor

Is there any interest in this functionality?

Unfortunately, I won't be able to add much beyond discussion in #289, as I no longer work on a project that uses PF4J and not aware of any recent changes to PF4J, and how they might interact with this feature. The considerations in #289 seem valid to me.

@decebals
Copy link
Member Author

@dmitry-timofeev Thanks! I want to see if other users see valuable this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants