New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed class variable for LinearGaussianCPDs #962
base: dev
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #962 +/- ##
======================================
Coverage ? 94.72%
======================================
Files ? 114
Lines ? 11201
Branches ? 0
======================================
Hits ? 10610
Misses ? 591
Partials ? 0
Continue to review full report at Codecov.
|
@Arijit-hydrated Thanks for the PR. Could you please also add a test case which would fail on the current version ? And after adding that, please squash both the commits into a single commit using |
@ankurankan Do you want me to add the test case which fails on the current version in the Fixes section above, where I referenced the relevant issue? Thanks :) |
@Arijit-hydrated No, we have unittests for the whole codebase (look into pgmpy/tests dir). So, I would like to have a tests added there for this specific issue. Let me know if something's not clear. |
@ankurankan This is the pull request for the issue #961 which is on high priority now. I noticed this was never merged. Can you elaborate what you want added in the unittests directory? |
@theUltraMarine19 Just a simple unit test which fails with the current code and gets fixed after merging the PR. |
Your checklist for this pull request
Fixes
Fixes Issue #961
Changes
Thank you!