Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed class variable for LinearGaussianCPDs #962

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

theUltraMarine19
Copy link
Contributor

Your checklist for this pull request

Fixes

Fixes Issue #961

Changes

  • Replaced variables with self.variables in init method of LinearGaussianCPD.py

Thank you!

@codecov
Copy link

codecov bot commented Dec 20, 2017

Codecov Report

❗ No coverage uploaded for pull request base (dev@fe2ca2c). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev     #962   +/-   ##
======================================
  Coverage       ?   94.72%           
======================================
  Files          ?      114           
  Lines          ?    11201           
  Branches       ?        0           
======================================
  Hits           ?    10610           
  Misses         ?      591           
  Partials       ?        0
Impacted Files Coverage Δ
pgmpy/factors/continuous/LinearGaussianCPD.py 31.03% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe2ca2c...66164e0. Read the comment docs.

@ankurankan
Copy link
Member

@Arijit-hydrated Thanks for the PR. Could you please also add a test case which would fail on the current version ? And after adding that, please squash both the commits into a single commit using git rebase. And please do try to follow: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html for commit messages.

@theUltraMarine19
Copy link
Contributor Author

@ankurankan Do you want me to add the test case which fails on the current version in the Fixes section above, where I referenced the relevant issue?

Thanks :)

@ankurankan
Copy link
Member

@Arijit-hydrated No, we have unittests for the whole codebase (look into pgmpy/tests dir). So, I would like to have a tests added there for this specific issue. Let me know if something's not clear.

@theUltraMarine19
Copy link
Contributor Author

theUltraMarine19 commented Sep 29, 2020

@ankurankan This is the pull request for the issue #961 which is on high priority now. I noticed this was never merged. Can you elaborate what you want added in the unittests directory?

@ankurankan
Copy link
Member

@theUltraMarine19 Just a simple unit test which fails with the current code and gets fixed after merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants