Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test for factor #963

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Conversation

lohani2280
Copy link
Contributor

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off our dev.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Refers #590

Changes

Please list the proposed changes in this pull request.

  • Separated the tests for Factor, TabularCPD and JointProbabilityDistribution classes
  • test_Factor: Added test for copy method
  • test_Factor: Added test for sum method
  • test_Factor: Added test for repr method of DiscreteFactor class
  • Added test for get_evidence method of TabularCPD class
  • Added test for to_factor method of TabularCPD class
  • test_JointProbabilityDistribution: Added test for copy method of JointProbabilityDistribution class
  • test_JointProbabilityDistribution: Added test for to_factor method of JointProbabilityDistribution class

💔Thank you!

@lohani2280
Copy link
Contributor Author

Ping @khalibartan @ankurankan

@ankurankan
Copy link
Member

@lohani2280 Sorry for replying so late. This will have to wait for a while till I push the refactor of the factor dir.

@lohani2280
Copy link
Contributor Author

@ankurankan No issues. I have added some additional test which were not present earlier. If you are free sometime,then please have a look and suggest necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants