Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redirect an Entire Site without Links section #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maidmaid
Copy link

@maidmaid maidmaid commented Jul 8, 2016

Hello!

We have redirection for
www.oldsite.com/some/crazy/link.html => www.newsite.com/some/crazy/link.html
but not for
www.oldsite.com/some/crazy/link.html => www.newsite.com/.

This PR adds this.

Copy link
Contributor

@rbowen rbowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using ^(.*)$ when you're not going to use the backreference is not recommended practice. Either just use ^ for the shortest-possible match, or just use the Redirect directive. The most important part about mod_rewrite is knowing when not to use it.

@Wouter0100
Copy link

Maybe better to use another naming for this, not "link" as it isn't really clear. Something like "path"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants