Add subclass driver #16353
Merged
Add subclass driver #16353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balsa-sarenac
suggested changes
Apr 11, 2024
src/SystemCommands-ClassCommands/SycCmAddSubclassCommand.class.st
Outdated
Show resolved
Hide resolved
added 9 commits
May 23, 2024 15:23
Add tests Migrate the Syc user pick e5f0165 Add RBAddNewClassRefactoring and ReAddSubclassDriver Add tests Migrate the Syc user pick 6e9c5a4 Add StRefactoringAddClassPresenter Update #SycCmAddSubclassCommand pick a763b30 Update privateTransform so we don't reparent classes in add subclass. Add event hooks in add class presenter.
Update #SycCmAddSubclassCommand
Add event hooks in add class presenter.
Enhance Add subclass UI
…m the driver. Fix the layout so comment presenter is bigger. Add use comment template checkbox. Refactoring initialize presenters. Show superclass in title dialog. Fix updating tag items. Temporary fix of onCancel: block using CmCommandAborted or CmdCommandAborted, both raising a Debugger when signaled.
hernanmd
force-pushed
the
add_subclass_driver
branch
from
5422119
to
0344b88
Compare
added 2 commits
May 23, 2024 15:30
…RBInsertNewClassRefactoring Remove unnecessary line in ReAddSubclassDriver>>configureRefactoring Remove unnecessary instance variable newClassPresenter in StRefactoringAddClassPresenter. Re-use 'textInput' from superclass. Update initialExtent setting. Remove unnecessary #example method.
balsa-sarenac
approved these changes
May 27, 2024
src/SystemCommands-ClassCommands/SycCmAddSubclassCommand.class.st
Outdated
Show resolved
Hide resolved
added 3 commits
May 27, 2024 16:06
Provide two instance creation helpers to provide a dialog with the superclass and its packages. Refactor ReAddSubclassDriver methods.
balsa-sarenac
approved these changes
May 28, 2024
balsa-sarenac
suggested changes
May 28, 2024
|
Two tests failing due to:
|
|
@hernanmd can you take the point of balsa into account so that we can integrate this issue. |
- the following classes have unused instance variables and should be cleaned: SycCmAddSubclassCommand - the following classes have uncategorized methods: an OrderedCollection(RBInteractionDriver) Re-use RBInsertNewClassRefactoring also for adding new refactoring
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a first version of "Add subclass" refactoring as a driver:
add_new_subclass_edit.mp4
Main features
blankCommentTemplatein the class selected as superclass.Implementation notes
RBAddNewClassRefactoringwhich differs from the Insert New Class refactoring in that does not reparent the subclasses to the new class.ReAddSubclassDriverandReAddSubclassDriverTest.Known issues
CmdCommandAborted signalandCmCommandAborted signalare failing right now and it should be investigated why (debugger keep opening which could mean the exception is not properly handled).