Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add windows and macos #140

Open
glimchb opened this issue Oct 31, 2023 · 2 comments · Fixed by #139 · May be fixed by #141
Open

ci: add windows and macos #140

glimchb opened this issue Oct 31, 2023 · 2 comments · Fixed by #139 · May be fixed by #141

Comments

@glimchb
Copy link
Contributor

glimchb commented Oct 31, 2023 •
edited

after #139 is merged we can add macos as well

see actions/runner-images#2150

need for macos

brew install docker colima

also see actions/runner-images#6216

implemented #139 and #141
@glimchb glimchb changed the title ci: add macos ci: add windows and macos Oct 31, 2023
@glimchb glimchb mentioned this issue Oct 31, 2023
Merged
glimchb added a commit to glimchb/gokv that referenced this issue Oct 31, 2023
@glimchb
ci: add windows to matrix tests
9c808dd 
Fixes philippgille#140

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb added a commit to glimchb/gokv that referenced this issue Oct 31, 2023
@glimchb
ci: add windows to matrix tests
7ceedb7 
Fixes philippgille#140

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb added a commit to glimchb/gokv that referenced this issue Oct 31, 2023
@glimchb
ci: add windows to matrix tests
725a448 
Fixes philippgille#140

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb added a commit to glimchb/gokv that referenced this issue Oct 31, 2023
@glimchb
ci: add windows to matrix tests
762875c 
Fixes philippgille#140

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@glimchb glimchb linked a pull request Oct 31, 2023 that will close this issue
Open
glimchb added a commit to glimchb/gokv that referenced this issue Oct 31, 2023
@glimchb
ci: add windows to matrix tests
1293384 
Fixes philippgille#140

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb added a commit to glimchb/gokv that referenced this issue Oct 31, 2023
@glimchb
ci: add windows to matrix tests
cafee56 
Fixes philippgille#140

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb added a commit to glimchb/gokv that referenced this issue Nov 7, 2023
@glimchb
ci: add windows to matrix tests
af6f1be 
Fixes philippgille#140

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb added a commit to glimchb/gokv that referenced this issue Nov 7, 2023
@glimchb
ci: add windows to matrix tests
9d2132b 
Fixes philippgille#140

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@philippgille
Copy link
Owner

Reopening manually, as it was closed automatically by merging #139 (and description mentioned this ticket), but that was for Windows only, MacOS is in draft here: #141

@philippgille philippgille reopened this Nov 11, 2023
@glimchb
Copy link
Contributor Author

glimchb commented Dec 28, 2023

Macos is ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: add windows to matrix tests glimchb/gokv
ci: add mac os to matrix tests glimchb/gokv
2 participants
@philippgille @glimchb