Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add mac os to matrix tests #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

glimchb
Copy link
Contributor

@glimchb glimchb commented Oct 31, 2023

Resolved #140

Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com

@glimchb glimchb force-pushed the macos branch 2 times, most recently from 72867a9 to 11d2270 Compare October 31, 2023 20:41
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b9cc3b) 56.69% compared to head (366fb51) 60.56%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   56.69%   60.56%   +3.87%     
==========================================
  Files          11       25      +14     
  Lines         822     2097    +1275     
==========================================
+ Hits          466     1270     +804     
- Misses        327      716     +389     
- Partials       29      111      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glimchb
Copy link
Contributor Author

glimchb commented Oct 31, 2023

fails on

Testing cockroachdb
ERROR: cannot dial server.
Is the server running?
If the server is running, check --host client-side and --advertise server-side.

timeout: context deadline exceeded
Failed running "sql"

Error: exit status 1
Error: Process completed with exit code 1.
56s

@glimchb
Copy link
Contributor Author

glimchb commented Nov 20, 2023

@philippgille I think is is ready to merge

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: add windows and macos
2 participants