Set the default for mailer depending on the value of ecto #5789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please look at the integration tests? thank you! |
|
I can fix the failing tests by explicitly enabling the mailer but I think it is a bad idea. It fixes the problem with issue #5786 but it might break for people who rely on the mailer just always being enabled by default. I believe this is a wont-fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the default value for the mailer binding (previously true) to the complement of the value of the ecto binding. That way the mailer gets disabled for Ecto projects by default but it is still possible to enable it using the
--mailercommand line flag. Fixes issue #5786.