Revert #4072 - don't use earthly for running integration tests #5817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteffenDE
changed the title
josevalim
approved these changes
May 20, 2024
SteffenDE
force-pushed
the
sd-revert-4072
branch
2 times, most recently
from
2133838
to
50d97b1
Compare
mcrumm
reviewed
May 21, 2024
|
@mcrumm I didn't like the duplicated code either. Now it's in a separate script used in both CI and the local docker wrapper. |
|
❤️❤️❤️🐥🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to look into fixing the integration tests and could not get earthly to run locally, while it was introduced in #4072 to make local testing easier. I also don't see a real advantage, because running the tests locally in docker is also quite easy without earthly, for example with the newly added
./docker.shscript in the integration_tests directory.