Feature request: Allow the use of the left and right arrow to navigate while in photo …

[tomplast]

What does it implement / fix / improve? Why?
I thought it would be useful (and intuitive) if you could use the keyboard arrows to navigate to previous and next image while in the photo edit dialog.

Are the changes related to an existing issue?
Nope.

[CLAassistant]

All committers have signed the CLA.

[graciousgrey]

Thank you very much for your contribution! We will have a look at this once the recently merged pull requests have been successfully released :)

[tomplast]

@graciousgrey Any updates :) ?

[lastzero]

Please note that we are out of the office until October 3 to get some rest after working on the new release. 🏝️💬

[graciousgrey]

The first tests look good so far :) It works in all browsers I have tested.
I just noticed that sometimes I have to click into the edit dialog before I can use the arrow keys.

[graciousgrey]

@tomplast We found one thing we need to resolve before we can merge this: The app must only navigate to the next edit dialog when the focus is not on an input field.

[tomplast]

@graciousgrey Functionality wise I think have fixed the issues you mentioned.

[graciousgrey]

Thank you! I will test your changes as soon as possible :)

[graciousgrey]

I just tested your latest changes.

I just noticed that sometimes I have to click into the edit dialog before I can use the arrow keys.

I have not observed this anymore 🎉

The app must only navigate to the next edit dialog when the focus is not on an input field.

I still see this behavior. The strange thing is that sometimes it works and sometimes it doesn't. One way around this could be to use a key combination that has no other function assigned to it, such as navigating in an input field. For example: shift key + arrow key.

I also realized that we need to prevent navigating to the next edit dialog when there are unsaved changes. For example, if a user has edited a field and not clicked Apply or Done, the changes will be lost when navigating to the next edit dialog. We could either prevent navigation without a message, or add a dialog that informs the user that there are unsaved changes and lets him save or discard them.

[tomplast]

Sorry for the late reply, I will try to look into it the coming week.

[graciousgrey]

No need to hurry :) We are currently busy with 2FA and OpenID Connect support, so we only have limited time to review changes over the next weeks.