Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of attachment icons and update example #336

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marceloandrioni
Copy link

Hello, just a simple PR in the docs with the list of icons (and their aspect ratio) for attachments. I got the info here.

@jbarlow83
Copy link
Member

Thanks. Apparently in PDF 2.0, the builtin attachment icons are gone and PDF generators must supply their own icons, so it would be better to have an example that embeds an icon since that is backward compatible. I'll have to look into this.

@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #336 (1e9a947) into master (ddac180) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #336   +/-   ##
=======================================
  Coverage   96.02%   96.02%           
=======================================
  Files          40       40           
  Lines        4054     4054           
=======================================
  Hits         3893     3893           
  Misses        161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddac180...1e9a947. Read the comment docs.

@marceloandrioni
Copy link
Author

Hello @jbarlow8. Yes, I only find out about the absence of default icons in pdf 2.0 after doing the PR. Apparently the icons needs to be included as an appearance stream (but I have no idea how to do this...). I opened the issue #337 regarding this subject and attached some example files.
I am no pdf expert but please let me know if I can help with anything (maybe testing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants