Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 8.1 in basic features #17194

Merged
merged 4 commits into from
May 24, 2024
Merged

add 8.1 in basic features #17194

merged 4 commits into from
May 24, 2024

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Apr 23, 2024 •
edited

What is changed, added or deleted? (Required)

Update basic features for v8.1:

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. for-release This PR relates to a TiDB release but does not have a tracked feature. v8.1 This PR/issue applies to TiDB v8.1. labels Apr 23, 2024
@Oreoxmt Oreoxmt self-assigned this Apr 23, 2024
@Oreoxmt Oreoxmt mentioned this pull request Apr 23, 2024
Merged
16 tasks
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 23, 2024
github-actions bot pushed a commit to Oreoxmt/pingcap-docsite-preview that referenced this pull request Apr 23, 2024
Preview PR pingcap/docs-cn#17194 and this preview is triggered from c…
1ed77de 
…ommit pingcap/docs-cn@5ff61f3
github-actions bot pushed a commit to Oreoxmt/pingcap-docsite-preview that referenced this pull request Apr 23, 2024
Preview PR pingcap/docs-cn#17194 and this preview is triggered from c…
bb3a3fa 
…ommit pingcap/docs-cn@673ffca
Oreoxmt
Oreoxmt commented May 6, 2024
View reviewed changes
basic-features.md
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview: https://pingcap-docsite-preview-git-v81-preview-oreoxmts-projects.vercel.app/zh/tidb/stable/basic-features

@hfxsd hfxsd self-requested a review May 6, 2024 07:44
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2024
@Oreoxmt Oreoxmt requested review from lilin90 and qiancai May 6, 2024 10:45
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 6, 2024

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

github-actions bot pushed a commit to Oreoxmt/pingcap-docsite-preview that referenced this pull request May 6, 2024
Preview PR pingcap/docs-cn#17194 and this preview is triggered from c…
46b9229 
…ommit pingcap/docs-cn@05ec9d5
lilin90
lilin90 reviewed May 7, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref: #17209

basic-features.md Outdated Show resolved Hide resolved
github-actions bot pushed a commit to Oreoxmt/pingcap-docsite-preview that referenced this pull request May 7, 2024
Preview PR pingcap/docs-cn#17194 and this preview is triggered from c…
f30b17d 
…ommit pingcap/docs-cn@44a72d3
@Oreoxmt Oreoxmt requested a review from songrijie May 10, 2024 03:09
songrijie
songrijie approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@songrijie songrijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 13, 2024

@songrijie: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt Oreoxmt added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels May 15, 2024
@Oreoxmt Oreoxmt requested a review from lilin90 May 20, 2024 06:30
@Oreoxmt Oreoxmt mentioned this pull request May 20, 2024
Merged
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-15 08:47:33.226461017 +0000 UTC m=+1643006.983596588: ☑️ agreed by qiancai.
  • 2024-05-22 06:14:53.914663418 +0000 UTC m=+2238647.671798992: ☑️ agreed by hfxsd.

@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented May 24, 2024

/unhold
/approve

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 24, 2024
This was referenced May 24, 2024
Merged
Merged
@ti-chi-bot ti-chi-bot bot merged commit f89f469 into pingcap:master May 24, 2024
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #17442.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request May 24, 2024
@Oreoxmt @ti-chi-bot
add 8.1 in basic features (pingcap#17194)
37aac6b
@ti-chi-bot ti-chi-bot mentioned this pull request May 24, 2024
Merged
16 tasks
ti-chi-bot bot pushed a commit that referenced this pull request May 24, 2024
@ti-chi-bot
add 8.1 in basic features (#17194) (#17442)
990b3ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songrijie songrijie songrijie approved these changes

@hfxsd hfxsd hfxsd approved these changes

@qiancai qiancai qiancai approved these changes

@Frank945946 Frank945946 Frank945946 approved these changes

@lilin90 lilin90 Awaiting requested review from lilin90

Assignees

@Oreoxmt Oreoxmt

Labels
approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.1 This PR/issue applies to TiDB v8.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Oreoxmt @ti-chi-bot @songrijie @lilin90 @hfxsd @qiancai @Frank945946