Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: add description for cdc behaviour change #17363

Merged
merged 18 commits into from
May 30, 2024
Merged

ticdc: add description for cdc behaviour change #17363

merged 18 commits into from
May 30, 2024

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented May 17, 2024 •
edited

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2024
@lidezhu lidezhu requested a review from flowbehappy May 17, 2024 07:55
@lidezhu lidezhu mentioned this pull request May 17, 2024
Merged
17 tasks
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 23, 2024

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lidezhu lidezhu requested a review from qiancai May 27, 2024 09:10
qiancai
qiancai reviewed May 27, 2024
View reviewed changes
ticdc/ticdc-behavior-change.md Outdated Show resolved Hide resolved
ticdc/ticdc-behavior-change.md Outdated Show resolved Hide resolved
ticdc/ticdc-behavior-change.md Outdated Show resolved Hide resolved
ticdc/ticdc-behavior-change.md Outdated Show resolved Hide resolved
ticdc/ticdc-behavior-change.md Outdated Show resolved Hide resolved
@qiancai qiancai self-assigned this May 27, 2024
@qiancai qiancai added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label May 27, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label May 27, 2024
lidezhu and others added 2 commits May 27, 2024 19:57
@lidezhu @qiancai
Apply suggestions from code review
526ade9 
Co-authored-by: Grace Cai <qqzczy@126.com>
@lidezhu
add more desc
0295281
qiancai
qiancai reviewed May 28, 2024
View reviewed changes
ticdc/ticdc-behavior-change.md Outdated Show resolved Hide resolved
ticdc/ticdc-behavior-change.md Outdated Show resolved Hide resolved
ticdc/ticdc-behavior-change.md Outdated Show resolved Hide resolved
@lidezhu @qiancai
Update ticdc/ticdc-behavior-change.md
be4e66d 
Co-authored-by: Grace Cai <qqzczy@126.com>
@qiancai qiancai added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels May 29, 2024
@Oreoxmt Oreoxmt self-requested a review May 29, 2024 06:09
@qiancai qiancai added the area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. label May 29, 2024
Oreoxmt
Oreoxmt approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-28 08:59:40.772596762 +0000 UTC m=+2766934.529732327: ☑️ agreed by qiancai.
  • 2024-05-29 06:24:04.172110472 +0000 UTC m=+2843997.929246045: ☑️ agreed by Oreoxmt.

@lidezhu @Oreoxmt
Apply suggestions from code review
98d2917 
Co-authored-by: Aolin <aolin.zhang@pingcap.com>
@qiancai
Copy link
Collaborator

qiancai commented May 30, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 30, 2024
@ti-chi-bot ti-chi-bot bot merged commit 228b322 into master May 30, 2024
6 of 7 checks passed
@ti-chi-bot ti-chi-bot bot deleted the add-cdc-behaviour-change0517 branch May 30, 2024 02:14
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request May 30, 2024
@lidezhu @ti-chi-bot
This is an automated cherry-pick of pingcap#17363
4083bb5 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #17477.

@ti-chi-bot ti-chi-bot mentioned this pull request May 30, 2024
Open
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #17478.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request May 30, 2024
@lidezhu @ti-chi-bot
This is an automated cherry-pick of pingcap#17363
e0ea4a6 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 30, 2024
Open
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #17479.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request May 30, 2024
@lidezhu @ti-chi-bot
This is an automated cherry-pick of pingcap#17363
1d81ac9 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced May 30, 2024
Open
Open
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #17480.

This was referenced May 30, 2024
Merged
Open
Open
Merged
ti-chi-bot bot pushed a commit that referenced this pull request May 30, 2024
@ti-chi-bot
ticdc: add description for cdc behaviour change (#17363) (#17480)
28b66da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@qiancai qiancai

Labels
approved area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lidezhu @qiancai @ti-chi-bot @flowbehappy @Oreoxmt