Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-increment: modify the description about the case of non-continuous auto increment id #17396

Merged
merged 4 commits into from
May 23, 2024

Conversation

tiancaiamao
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

pingcap/tidb#53315

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 20, 2024
@Oreoxmt Oreoxmt added for-release This PR relates to a TiDB release but does not have a tracked feature. v8.1 This PR/issue applies to TiDB v8.1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels May 20, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label May 20, 2024
@Oreoxmt Oreoxmt requested a review from qiancai May 20, 2024 09:15
auto-increment.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented May 20, 2024

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

auto-increment.md Outdated Show resolved Hide resolved
Co-authored-by: Grace Cai <qqzczy@126.com>
auto-increment.md Outdated Show resolved Hide resolved
auto-increment.md Outdated Show resolved Hide resolved
auto-increment.md Outdated Show resolved Hide resolved
@qiancai qiancai requested a review from Oreoxmt May 22, 2024 03:01
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label May 23, 2024
Copy link

ti-chi-bot bot commented May 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-22 03:01:23.666063415 +0000 UTC m=+2227037.423198988: ☑️ agreed by qiancai.
  • 2024-05-23 01:42:39.931796439 +0000 UTC m=+2308713.688932013: ☑️ agreed by Oreoxmt.

@qiancai
Copy link
Collaborator

qiancai commented May 23, 2024

/approve

Copy link

ti-chi-bot bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 23, 2024
@qiancai
Copy link
Collaborator

qiancai commented May 23, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 1387f83 into pingcap:master May 23, 2024
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #17433.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.1 This PR/issue applies to TiDB v8.1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants