br/restore: use a more relax check for changefeeds when restoring

[YuJuncen]

What problem does this PR solve?

Issue Number: close #53131

Problem Summary:
In the current version, we will reject to restore once there is any changefeed.
This is too strict and not pretty friendly to the end user.

What changed and how does it work?

For now, we will only reject to restore when the changefeed:

• Have a checkpoint earlier than the backup time for this restore.
• Is not failed.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

1. Create such a changefeed:

function run
  changefeedctl create --sink-uri=blackhole:// --no-confirm -c $argv[1] --start-ts (pdctl service-gc-safepoint | jq .gc_safe_point)
  changefeedctl pause -c $argv[1]
end
run test

2. Backup the cluster with:

./br backup full -s (s3path tpcc-10)

3. Then, restore the backup, should fail:

root@xanadu ~/op# ./br restore full -s (s3path tpcc-10)
Detail BR log in /tmp/br.log.2024-05-09T14.17.38+0800
[2024/05/09 14:17:42.087 +08:00] [INFO] [collector.go:77] ["Full Restore failed summary"] [total-ranges=0] [ranges-succeed=0] [ranges-failed=0]
Error: found CDC changefeed(s): cluster/namespace: default/default changefeed(s): [test], please remove changefeed(s) before restore

4. Resume the changefeed and wait it proceed.

changefeedctl resume -c test

5.Now the BR passed the CDC check (BR still fail due to we are trying to restore to the origin cluster, that is expected.)

root@xanadu ~/op# ./br restore full -s (s3path tpcc-10)
Detail BR log in /tmp/br.log.2024-05-09T14.23.18+0800
[2024/05/09 14:23:22.117 +08:00] [INFO] [collector.go:77] ["Full Restore failed summary"] [total-ranges=0] [ranges-succeed=0] [ranges-failed=0]
#######################################################################
# the target cluster is not fresh, cannot restore.
# you can drop existing databases and tables and start restore again
#######################################################################
Error: user db/tables: test, warehouse, district, customer, history, new_order, orders, order_line, stock, item: [BR:Restore:ErrRestoreNotFreshCluster]cluster is not fresh

• No need to test

  • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Now, restore from an archive old enough won't be conflict with TiCDC changefeeds.

[tiprow]

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 69.34307% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 75.5631%. Comparing base (f304f04) to head (cbbd432).
Report is 56 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #53121        +/-   ##
================================================
+ Coverage   72.4716%   75.5631%   +3.0915%     
================================================
  Files          1491       1519        +28     
  Lines        429012     449567     +20555     
================================================
+ Hits         310912     339707     +28795     
+ Misses        98878      88682     -10196     
- Partials      19222      21178      +1956     

Flag	Coverage Δ
integration	53.5457% <56.9343%> (?)
unit	71.2557% <63.9705%> (-0.1084%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (ø)
parser	∅ <ø> (∅)
br	61.1969% <46.6666%> (+19.7534%)	⬆️

[sdojjy]

namespace is a part of changefeed ID

[YuJuncen]

Here I'm going to try keep the old output format. Some of test cases rely on it.

[sdojjy]

error state still block gc, it's the same with warning

[sdojjy]

ignore changefeeds in finished state

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-05-09 06:46:27.023852027 +0000 UTC m=+1117340.780987604: ☑️ agreed by sdojjy.
• 2024-05-13 03:19:08.814865858 +0000 UTC m=+1450502.572001428: ☑️ agreed by Leavrth.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, Leavrth, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [D3Hunter,Leavrth,sdojjy]
• br/OWNERS [Leavrth]
• lightning/OWNERS [D3Hunter]
• pkg/executor/importer/OWNERS [D3Hunter]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment