Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: allow configure the desired size and number of rows of each INSERT statement for logical mode (#46997) #53159

Open
wants to merge 2 commits into
base: release-7.5
Choose a base branch
from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #46997

What problem does this PR solve?

Issue Number: close #46607

Problem Summary:

What is changed and how it works?

Added a config values tikv-importer.logical-import-batch-{size,rows} which controls how big the INSERT statement would be when using logical mode.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

In Lightning logical mode, the length of the INSERT statements executed downstream can now be changed from the default 1.0 MiB. Decreasing this allows reducing performance impact caused by large transaction.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Copy link

ti-chi-bot bot commented May 10, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lance6716 and additionally assign easonn7, yujuncen for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 12 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-7.5@12c763f). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #53159   +/-   ##
================================================
  Coverage               ?   71.9897%           
================================================
  Files                  ?       1411           
  Lines                  ?     409772           
  Branches               ?          0           
================================================
  Hits                   ?     294994           
  Misses                 ?      94924           
  Partials               ?      19854           
Flag Coverage Δ
unit 71.9897% <53.8461%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4018% <0.0000%> (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants