-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl,mdl: fix the issue that the table_ids overlap regex is not correct (#52879) #53190
ddl,mdl: fix the issue that the table_ids overlap regex is not correct (#52879) #53190
Conversation
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #53190 +/- ##
================================================
Coverage ? 71.2848%
================================================
Files ? 1465
Lines ? 422303
Branches ? 0
================================================
Hits ? 301038
Misses ? 100827
Partials ? 20438
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: easonn7, wjhuang2016, YangKeao, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #52879
What problem does this PR solve?
Issue Number: close #52758
Problem Summary:
The regexp in
mdl_view
is not correct:This SQL will return 1, because it actually matches ',1' or '2,'.
What changed and how does it work?
This PR modified the REGEXP from
,1|2,
to,(1|2),
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.