planner: move loical plan functionality AppendCandidate4PhysicalOptimizeOp to util #53198
Conversation
…util Signed-off-by: AilinKid <314806019@qq.com>
ti-chi-bot
bot
added
release-note-none
sig/planner
|
Hi @AilinKid. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53198 +/- ##
================================================
+ Coverage 72.4267% 73.9613% +1.5345%
================================================
Files 1492 1493 +1
Lines 429231 429991 +760
================================================
+ Hits 310878 318027 +7149
+ Misses 99087 92029 -7058
- Partials 19266 19935 +669
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pkg/planner/core/find_best_task.go
Outdated
| @@ -53,6 +54,10 @@ var PlanCounterDisabled base.PlanCounterTp = -1 | |||
|
|
|||
| var invalidTask = &RootTask{} // invalid if p is nil | |||
|
|
|||
| func init() { | |||
There was a problem hiding this comment.
planner/core has 4 init function. Should we merge those together?
ti-chi-bot
bot
added
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
…izeOp to util (pingcap#53198) ref pingcap#51664, ref pingcap#52714
…izeOp to util (pingcap#53198) ref pingcap#51664, ref pingcap#52714
What problem does this PR solve?
Issue Number: ref #51664, ref #52714
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.