Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*(cdc): accept access denied error when query tidb_version #11129

Merged
merged 2 commits into from
May 20, 2024

Conversation

lidezhu
Copy link
Collaborator

@lidezhu lidezhu commented May 17, 2024

What problem does this PR solve?

Issue Number: close #11128

What is changed and how it works?

When the downstream is a mysql cluster behind a workload balancer on the cloud, the workload balancer may provide an access point using domain name;
When cdc access the downstream using the domain name, the connection will use database information_schema automatically. In this case, when query select tidb_version(), the downstream will report error for non-root user like: Access denied for user xxx to database 'information_schema'.
image

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 17, 2024
@lidezhu
Copy link
Collaborator Author

lidezhu commented May 17, 2024

/retest

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 57.6075%. Comparing base (61efa5f) to head (44e9837).
Report is 4 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 62.0433% <0.0000%> (+0.0736%) ⬆️
dm 51.2560% <ø> (+0.0524%) ⬆️
engine 63.4232% <ø> (+0.0282%) ⬆️
Flag Coverage Δ
unit 57.6075% <0.0000%> (+0.0619%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11129        +/-   ##
================================================
+ Coverage   57.5456%   57.6075%   +0.0619%     
================================================
  Files           854        854                
  Lines        126053     126124        +71     
================================================
+ Hits          72538      72657       +119     
+ Misses        48123      48077        -46     
+ Partials       5392       5390         -2     

@lidezhu
Copy link
Collaborator Author

lidezhu commented May 17, 2024

/test dm-integration-test

@lidezhu lidezhu added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels May 17, 2024
@lidezhu
Copy link
Collaborator Author

lidezhu commented May 17, 2024

/test dm-integration-test

Copy link
Contributor

ti-chi-bot bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [asddongmen,hongyunyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented May 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-20 02:16:14.627791897 +0000 UTC m=+2051528.384927469: ☑️ agreed by asddongmen.
  • 2024-05-20 02:53:07.76994353 +0000 UTC m=+2053741.527079103: ☑️ agreed by hongyunyan.

@lidezhu
Copy link
Collaborator Author

lidezhu commented May 20, 2024

/test dm-integration-test

1 similar comment
@lidezhu
Copy link
Collaborator Author

lidezhu commented May 20, 2024

/test dm-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 5bf52d5 into pingcap:master May 20, 2024
28 checks passed
@lidezhu lidezhu deleted the fix-create-changefeed-0517 branch May 20, 2024 03:58
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11139.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #11140.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #11141.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11142.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create changefeed failed with error: Access denied for user xxx to database 'information_schema'
4 participants