Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Cleanup Kafka Configuration #10558

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Dec 15, 2023

No description provided.

@emeroad emeroad added this to the 3.0.0 milestone Dec 15, 2023
@emeroad emeroad force-pushed the #noissue_kafa branch 2 times, most recently from 4789a30 to e222f24 Compare December 15, 2023 09:48
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (84af3be) 37.70% compared to head (e222f24) 38.12%.
Report is 1 commits behind head on master.

❗ Current head e222f24 differs from pull request most recent head b6c26f8. Consider uploading reports for the commit b6c26f8 to get more accurate results

Files Patch % Lines
...rcorp/pinpoint/pinot/kafka/KafkaConfiguration.java 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10558      +/-   ##
============================================
+ Coverage     37.70%   38.12%   +0.42%     
- Complexity    11869    11900      +31     
============================================
  Files          3808     3761      -47     
  Lines         94441    94532      +91     
  Branches      10250    10296      +46     
============================================
+ Hits          35607    36039     +432     
+ Misses        55889    55499     -390     
- Partials       2945     2994      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant