-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Terrain Disappearing #5829
base: master
Are you sure you want to change the base?
Fix Terrain Disappearing #5829
Conversation
Added comments explaining rough purpose of the centroid to header. Fixed up DEBUG_CENTROIDS rendering and materials
@Web-eWorks dammit I did some testing last night and this doesn't 100% fix it, It's much improved but I still get some drop-out 😔 |
@fluffyfreak I assume it means that the understanding of the bug was mostly correct? |
@impaktor it's on the right track, I just don't understand what exactly has changed that it's become a problem suddenly |
I assumed this was something that's been in master a long time (since no change has been made to terrain / render in a long time, that I can think of), but was rare (as it's not been reported before). |
Fixes #5806 ... if we're lucky
Switched to using the recalculated
m_centroid
instead ofm_clipCentroid
which is surprisingly far below the surface on asteroids. I believe some terrains generate heights which are FAR above expected which buriesm_clipCentroid
much further below the surface than expected.All of this will need some testing with things to look out for like: