Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache test data to be sent until WebSocket connection gets established #350

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rolandkakonyi
Copy link

Problem

If the first test finishes before the socket connection is established, it never gets reported to the CLI server.

Changed

Added a temporary cache to store results until connection gets established, then send the results to the CLI server.

@rolandkakonyi rolandkakonyi force-pushed the fix-socket-race-condition-with-too-quick-tests branch from c4f4d01 to f9a7147 Compare November 16, 2023 14:02
@JonathanAndrews
Copy link
Contributor

Hi @rolandkakonyi,

This looks great!

Although this is a relatively small change, we've not got capacity to review, merge and release this right now. We'll try and get this reviewed and merged before Christmas.

Thanks for submitting a PR, we really appreciate it 🙏

Jonathan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants