-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Use correct terminology to avoid confusion #6832
base: master
Are you sure you want to change the base?
Conversation
Thanks @hyiltiz! Clearly we weren't aware of this convention when we created our implementation of the box plot, but it does look to me as though the distinction you're describing is used fairly consistently in the stats community. Unfortunately, this naming is part of the API, for example: plotly.js/src/traces/box/attributes.js Lines 113 to 134 in f6c33bd
(oops part of the So it would be a breaking change to alter that now, and I don't think this is severe enough to warrant that big a step. I suggest we leave the API as is and address the confusion in the docs / descriptions. The hover text labels we could certainly change, though I'll note that this is not so simple either since it's included in all the translations, so we would need to update those too, or add some custom code to fall back on the translation of |
Thank you so much for the prompt feedback! I was confused about the hover text that I saw from
As this warrants no urgent work, it would probably make sense to change all translations at once rather than going through the hassle of falling back to the incorrect terminology. This terminology can become especially confusing as the data becomes less Gaussian-like (e.g. a trimodal dataset, depending on the distance between the modes, drawing whiskers vs. fences would really make a large difference). |
Uses correct terminology to avoid confusion around whiskers vs. fences. Fences are defined as the bounds around the quartiles, whose length always equals
k IQR
(plotly adoptsk = 1.5
). Whiskers finds the data point closest to this bound instead. Plotly implements the latter, hence should use correct names.https://stats.stackexchange.com/questions/149161/confused-by-location-of-fences-in-box-whisker-plots