Improve numerical stability of 3D projection #6998

hborchardt · 2024-05-15T12:45:24Z

When the position vector has large values that are cancelled out by large values in the model matrix, it is more numerically stable to first multiply the position by the model matrix instead of multiplying the matrices together first.

This should always yield equivalent or more accurate results.

Use forks of the gl-vis libraries that use the problematic pattern.

Helps with #3306
See gl-vis/gl-axes3d#23

When the position vector has large values that are cancelled out by large values in the model matrix, it is more numerically stable to first multiply the position by the model matrix instead of multiplying the matrices together first. Use forks of the gl-vis libraries that use the problematic pattern.

archmoj · 2024-05-15T13:06:04Z

Thanks for the PR.
Please download baselines.tar from https://app.circleci.com/pipelines/github/plotly/plotly.js/10465/workflows/5b8aa5a0-5c2e-4237-b231-604b94893e2b/jobs/229556/artifacts
Then extract the files and replace them in test/image/baselines; commit and push.

archmoj · 2024-05-15T13:45:44Z

Please add gl3d_mesh3d_surface3d_scatter3d_line3d_error3d_log_reversed_ranges to this list:

plotly.js/test/image/compare_pixels_test.js

Lines 176 to 181 in 8b09892

    
           'gl3d_ibm-plot', 
        
           'gl3d_isosurface_2surfaces-checker_spaceframe', 
        
           'gl3d_opacity-scaling-spikes', 
        
           'gl3d_cone-wind', 
        
           'gl3d_isosurface_math', 
        
           'gl3d_scatter3d-blank-text'

which would help test-baselines-virtual-webgl pass.

stackgl_modules/package.json

archmoj · 2024-05-15T14:28:59Z

stackgl_modules/package.json

-    "gl-cone3d": "^1.6.0",
-    "gl-error3d": "^1.0.16",
+    "gl-axes3d": "github:hborchardt/gl-axes3d#83caafc058b2d60b6006e26432967c411c125fe1",
+    "gl-cone3d": "github:hborchardt/gl-cone3d#e9728cd068e0dfe11b92c5785974cd463f78c01c",


Please open pull requests on all gl-vis/* dependencies and paste the links for every line change in package.json file. Thank you!

See gl-vis/gl-cone3d#21

Now: gl-cone3d@1.6.1

hborchardt · 2024-05-15T14:34:47Z

stackgl_modules/package.json

-    "gl-error3d": "^1.0.16",
+    "gl-axes3d": "github:hborchardt/gl-axes3d#83caafc058b2d60b6006e26432967c411c125fe1",
+    "gl-cone3d": "github:hborchardt/gl-cone3d#e9728cd068e0dfe11b92c5785974cd463f78c01c",
+    "gl-error3d": "github:hborchardt/gl-error3d#ee55620d17f3cc7dfb104823c904f5070aba79ed",


See gl-vis/gl-error3d#12

Now: gl-error3d@1.0.17

hborchardt · 2024-05-15T14:35:09Z

stackgl_modules/package.json

    "gl-heatmap2d": "^1.1.1",
-    "gl-line3d": "1.2.1",
-    "gl-mesh3d": "^2.3.1",
+    "gl-line3d": "github:hborchardt/gl-line3d#27123949f65e2d8deab6a6e131030073ed9cdf02",


See gl-vis/gl-line3d#15

Now: gl-line3d@1.2.2

hborchardt · 2024-05-15T14:35:27Z

stackgl_modules/package.json

-    "gl-line3d": "1.2.1",
-    "gl-mesh3d": "^2.3.1",
+    "gl-line3d": "github:hborchardt/gl-line3d#27123949f65e2d8deab6a6e131030073ed9cdf02",
+    "gl-mesh3d": "github:hborchardt/gl-mesh3d#be2c7fcb68e70e001bbfb8021380d0d7ac75b1c9",


See gl-vis/gl-mesh3d#23

Now: gl-mesh3d@2.3.2

hborchardt · 2024-05-15T14:35:48Z

stackgl_modules/package.json

    "gl-plot2d": "^1.5.0",
    "gl-plot3d": "^2.4.7",
    "gl-pointcloud2d": "^1.0.3",
-    "gl-scatter3d": "^1.4.0",
+    "gl-scatter3d": "github:hborchardt/gl-scatter3d#086177000f405bc72f171350f9c1efa6eb523e29",


See gl-vis/gl-scatter3d#23

Now: gl-scatter3d@1.4.1

hborchardt · 2024-05-15T14:36:04Z

stackgl_modules/package.json

    "gl-select-box": "^1.0.4",
    "gl-shader": "4.3.1",
    "gl-spikes2d": "^1.0.2",
-    "gl-streamtube3d": "^1.4.1",
-    "gl-surface3d": "^1.6.0",
+    "gl-spikes3d": "github:hborchardt/gl-spikes3d#9ad06b2dd48fa19d2faa54e5645c2e4bf5e6157c",


See gl-vis/gl-spikes3d#6

Now: gl-spikes3d@1.0.11

hborchardt · 2024-05-15T14:36:18Z

stackgl_modules/package.json

-    "gl-streamtube3d": "^1.4.1",
-    "gl-surface3d": "^1.6.0",
+    "gl-spikes3d": "github:hborchardt/gl-spikes3d#9ad06b2dd48fa19d2faa54e5645c2e4bf5e6157c",
+    "gl-streamtube3d": "github:hborchardt/gl-streamtube3d#29c914cc0d88fc5dffce62dcd8169f38115d078b",


See gl-vis/gl-streamtube3d#13

Now: gl-streamtube3d@1.4.2

hborchardt · 2024-05-15T14:36:30Z

stackgl_modules/package.json

-    "gl-surface3d": "^1.6.0",
+    "gl-spikes3d": "github:hborchardt/gl-spikes3d#9ad06b2dd48fa19d2faa54e5645c2e4bf5e6157c",
+    "gl-streamtube3d": "github:hborchardt/gl-streamtube3d#29c914cc0d88fc5dffce62dcd8169f38115d078b",
+    "gl-surface3d": "github:hborchardt/gl-surface3d#0728e33c0296c602b147e8f1ea8f1bfe7040c61e",


See gl-vis/gl-surface3d#20

Please install the patch.

npm i gl-surface3d@1.6.1

archmoj · 2024-05-15T14:53:36Z

Looking at the diffs of baselines (https://app.circleci.com/pipelines/github/plotly/plotly.js/10465/workflows/5b8aa5a0-5c2e-4237-b231-604b94893e2b/jobs/229556/artifacts), the changes are not remarkable on most of except the one ussing dates and larger numbers which is a good sign of fixing the bug.
For reference I pasted the diff of gl3d_world-cals mock below.

Would you please paste two short videos interacting with gl3d_world-cals or other mock showing before and after effects?

archmoj · 2024-05-15T15:34:27Z

For the before vs after video you may fork and tweak this codepen.

hborchardt · 2024-05-15T15:38:58Z

stackgl_modules/package.json

-    "gl-axes3d": "^1.7.0",
-    "gl-cone3d": "^1.6.0",
-    "gl-error3d": "^1.0.16",
+    "gl-axes3d": "github:hborchardt/gl-axes3d#fcc1c5c49db3de6445020a63a5d76403ec5a2b98",


See gl-vis/gl-axes3d#23

Please install the patch.

npm i gl-axes3d@1.7.1

hborchardt · 2024-05-15T16:31:14Z

For gl3d_world-cals, I scaled the z axis values to be within a few hours, to make the problem apparent.
On master:
old.webm
On this branch:
new.webm

Unfortunately this did not fix the jagged edges of the surface plot - would have been nice.

archmoj · 2024-05-15T20:06:21Z

@hborchardt , please install new patches of gl-vis modules and we should be good to go 🚀

draftlogs/6998_fix.md

archmoj · 2024-05-16T11:10:40Z

Excellent community PR. Cc: @Coding-with-Adam

Thanks very much @hborchardt
🎖️ 🏅 🥇 🥈 🥉 🏆 ⭐ 🌟 for each of those many dependency fixes :)

archmoj · 2024-05-29T10:03:08Z

Plotly.js v2.33.0 is out: https://github.com/plotly/plotly.js/releases/tag/v2.33.0
Thanks for your contribution.

archmoj added type: bug type: community status: reviewable labels May 15, 2024

hborchardt added 2 commits May 15, 2024 15:09

Update 3D baseline images

04c9076

Add draftlog

c86d4a3

Add one testcase to flaky virtual-webgl tests list

bfb44e2

archmoj reviewed May 15, 2024

View reviewed changes

stackgl_modules/package.json Outdated Show resolved Hide resolved

Remove overrides in stackgl_modules package.json

0510d91

archmoj reviewed May 15, 2024

View reviewed changes

stackgl_modules/package.json Outdated Show resolved Hide resolved

archmoj reviewed May 15, 2024

View reviewed changes

hborchardt commented May 15, 2024

View reviewed changes

Update gl-axes3d

148dfa2

hborchardt commented May 15, 2024

View reviewed changes

archmoj mentioned this pull request May 15, 2024

Improve numerical stability of projection gl-vis/gl-streamtube3d#13

Merged

Update gl-vis dependencies to new upstream versions

d872c2b

archmoj reviewed May 16, 2024

View reviewed changes

draftlogs/6998_fix.md Outdated Show resolved Hide resolved

Update draftlogs/6998_fix.md

04fcdb6

archmoj merged commit cfccbcc into plotly:master May 16, 2024
1 check failed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve numerical stability of 3D projection #6998

Improve numerical stability of 3D projection #6998

hborchardt commented May 15, 2024

archmoj commented May 15, 2024

archmoj commented May 15, 2024

archmoj May 15, 2024

hborchardt May 15, 2024

archmoj May 15, 2024

hborchardt May 15, 2024

archmoj May 15, 2024

hborchardt May 15, 2024 •

edited

archmoj May 15, 2024

hborchardt May 15, 2024

archmoj May 15, 2024

hborchardt May 15, 2024

archmoj May 15, 2024

hborchardt May 15, 2024

archmoj May 15, 2024

hborchardt May 15, 2024

archmoj May 15, 2024

hborchardt May 15, 2024

archmoj May 15, 2024

archmoj commented May 15, 2024

archmoj commented May 15, 2024

hborchardt May 15, 2024

archmoj May 15, 2024

hborchardt commented May 15, 2024

archmoj commented May 15, 2024

archmoj commented May 16, 2024

archmoj commented May 29, 2024

Improve numerical stability of 3D projection #6998

Improve numerical stability of 3D projection #6998

Conversation

hborchardt commented May 15, 2024

archmoj commented May 15, 2024

archmoj commented May 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hborchardt May 15, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

archmoj commented May 15, 2024

archmoj commented May 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hborchardt commented May 15, 2024

archmoj commented May 15, 2024

archmoj commented May 16, 2024

archmoj commented May 29, 2024

hborchardt May 15, 2024 •

edited