Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(errors): surface react docker errors to front end [EE-7053] #11726

Merged
merged 2 commits into from May 13, 2024

Conversation

testA113
Copy link
Contributor

@testA113 testA113 commented Apr 30, 2024

Closes EE-7053

@@ -11,6 +10,7 @@ import {
} from '@/react-tools/react-query';

import { queryKeys as dockerQueryKeys } from '../../queries/utils';
import { addNodeName } from '../../proxy/addNodeName';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are adding node header. addNodeName does seem a bit less described to me. addNodeHeader so something

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice comment, will update this existing function name

@testA113 testA113 merged commit 6b5a402 into develop May 13, 2024
18 checks passed
@testA113 testA113 deleted the fix/EE-5611/EE-7053/surface-react-docker-errors branch May 13, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants