Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mbox to social links #316

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

mnlc
Copy link

@mnlc mnlc commented Feb 16, 2020

Hi,

When the social links section breaks to two lines an icon stay on first row

image

Some mbox should fix the behavior

image

@OJFord
Copy link
Collaborator

OJFord commented Nov 22, 2021

Hi @mnlc, thanks, this LGTM (ideally I suppose we'd drop the trailing | on the first line, but it's an improvement for sure) - if you're still interested could you rebase to fix conflicts please, and then CI should run just so we can double check it looks right on the example.

@github-actions github-actions bot added the size/S Small size issue or PR. label Jan 13, 2024
@mnlc
Copy link
Author

mnlc commented Jan 13, 2024

Hi @OJFord, I was thinking could be time to merge this lol. I haven't done the improvement, instead updated to wrap the added items in the meantime. I made a test uncommenting some socials, seems good. thanks

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Small size issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants