Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to use Font Awesome 6 #418

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xaviermawet
Copy link
Contributor

Hi,

This pull request adds latex commands for Font Awesome 6.1.1 free icons (inspired by #258 and #235).

Since there is no official FontAwesome6 package yet, I created a node application (latex-fontawesome) that consumes the Font Awesome GraphQL API to get icons metadata and generate definitions (sty file). Logic is based on plorcupine's latex-fontawesome project.

Steps in order to use icons from so-generated fontawesome6.sty file:

  1. Use search on the official website to find icon by name or related tags.
  2. Use unicode of the desired icon to search for latex definition in fontawesome6.sty.
  3. Copy and paste the associated definition in your latex document.

@github-actions
Copy link

This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR.

@github-actions github-actions bot added the size/XL Extra Large size issue or PR. label Mar 25, 2022
@OJFord
Copy link
Collaborator

OJFord commented Mar 26, 2022

I've only quickly skimmed, but based on that the bot's comment seems unreasonable! Thanks for the PR, will look properly shortly.

@github-actions
Copy link

github-actions bot commented Apr 2, 2022

This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR.

@OJFord OJFord added dependencies Pull requests that update a dependency file and removed size/XL Extra Large size issue or PR. labels Apr 6, 2022
Copy link
Collaborator

@OJFord OJFord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm certainly in favour of keeping the dependency up to date, but I'm not sure how I feel about bundling it rather than using a version published on CTAN.

Have you considered publishing yours?

awesome-cv.cls Outdated Show resolved Hide resolved
awesome-cv.cls Outdated Show resolved Hide resolved
awesome-cv.cls Show resolved Hide resolved
awesome-cv.cls Outdated Show resolved Hide resolved
awesome-cv.cls Outdated Show resolved Hide resolved
@github-actions
Copy link

This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR.

@github-actions github-actions bot added the size/XL Extra Large size issue or PR. label Apr 14, 2022
@xaviermawet
Copy link
Contributor Author

I'm certainly in favour of keeping the dependency up to date, but I'm not sure how I feel about bundling it rather than using a version published on CTAN.

Have you considered publishing yours?

I've never created or published a package on CTAN. I'm gonna try to do it and thus update my PR

@github-actions
Copy link

This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR.

@github-actions
Copy link

This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR.

@github-actions
Copy link

This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR.

@OJFord
Copy link
Collaborator

OJFord commented Jul 14, 2022

Any luck with CTAN @xaviermawet?

@xaviermawet
Copy link
Contributor Author

Hi @OJFord, I'll look into it very soon but with work and family, I haven't found the time to do it yet.
I also contacted Marcel Fabian Krüger, author of the fontawesome5 package, and he told me he had no plan to create a
fontawesome6 package.
I keep you informed in the coming weeks

@OJFord
Copy link
Collaborator

OJFord commented Jul 21, 2022

Of course, no problem, just noticed you added some commits do wondered if you'd managed it.

Cheers

@cats256
Copy link

cats256 commented Aug 5, 2022

I planned on opening a pull request for this but then I realized there's already one opened. Why not just remove (or comment on) \RequirePackage{fontawesome} in awesome-cv.cls and add a new package in resume.tex using \usepackage{fontawesome5}? |

Edit: Never mind. I just realized the font package is already Font Awesome 5

@xaviermawet
Copy link
Contributor Author

xaviermawet commented Aug 16, 2022

I uploaded a package named fontawesome6 on CTAN. I'm waiting for validation !

@OJFord
Copy link
Collaborator

OJFord commented Aug 19, 2022

Oh great, nice one 🙂

@cats256
Copy link

cats256 commented Aug 26, 2022

@xaviermawet I can't find the package on CTAN

@xaviermawet
Copy link
Contributor Author

@willb256 the package hasn't been validated yet. I'm currently discussing with one CTAN's validator and the authors of others fontawesome packages to synchronize us about the package naming vs fontawesome version, the macros collision with other fontawesome packages, etc... So my package isn't available yet because it didn't pass the validation phase right now. But it should be available soon. Stay tune !

@Loco169976
Copy link

🥺

@github-actions
Copy link

This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR.

@github-actions
Copy link

This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR.

@OJFord
Copy link
Collaborator

OJFord commented Nov 29, 2023

This bot seems a bit annoying @posquit0, I'm not sure we get enough (genuine) PRs that we can't make that judgement 'manually' - any objection to turning it off? Or at least only running on PR creation, not every update (which can get very noisy as here).

@posquit0
Copy link
Owner

posquit0 commented Dec 1, 2023

For now, I've excluded the binary files and the examples directory for pull-request-labler action. I don't think this will solve the problem, so I'll look into something else soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file size/XL Extra Large size issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants