\cvhonor: Omit comma if honortitle is empty #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
OJFord
reviewed
Jul 27, 2023
| @@ -692,7 +692,7 @@ | |||
| % Define a line of cv information(honor, award or something else) | |||
| % Usage: \cvhonor{<position>}{<title>}{<location>}{<date>} | |||
| \newcommand*{\cvhonor}[4]{% | |||
| \honordatestyle{#4} & \honorpositionstyle{#1}, \honortitlestyle{#2} & \honorlocationstyle{#3} \\ | |||
| \honordatestyle{#4} & \honorpositionstyle{#1}\ifthenelse{\equal{#2}{}}{}{,} \honortitlestyle{#2} & \honorlocationstyle{#3} \\ | |||
There was a problem hiding this comment.
Suggested change
| \honordatestyle{#4} & \honorpositionstyle{#1}\ifthenelse{\equal{#2}{}}{}{,} \honortitlestyle{#2} & \honorlocationstyle{#3} \\ | |
| \honordatestyle{#4} & \honorpositionstyle{#1}\ifempty{#2}{}{,} \honortitlestyle{#2} & \honorlocationstyle{#3} \\ |
is clearer I think?
Do we need similar for #3 spacing if that's empty?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed this for my own, figured someone else might want it as well
It's the first way I thought of, feel free to push directly to the branch if there's a better way to do it