Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show page num of CV and resume in currentPage/totalPage style #482

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sjiang95
Copy link

Motivation

The CV and resume of this repo is designed for digital distributions. But there are cases where paper CV and resume need to be distributed (e.g., an offline career fair). In such cases, it is important to make sure that the receiver can be aware of whether the document in its hand is complete.

The current page number style excludes the information of how many pages in total are the documents.

Solution

One simple solution is print page numbers of 'cv.tex' and 'resume.tex' in currentPage/totalPage style.

Changes

Use the \pageref*{LastPage} command of lastpage package.

Preview

Use cv.tex

current master:
image

this pr:
image

@github-actions github-actions bot added the size/XS Extra Small size issue or PR. label Jul 29, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Welcome! Looks like this is your first pull request.

Hey, thanks for your contribution! Please give us a bit of time to review it. 😄

@OJFord
Copy link
Collaborator

OJFord commented Jul 29, 2023

I'm inclined to agree, think I would personally use this, but I'd be more comfortable merging if we could make it optional - i.e. default to the current behaviour so we don't change people's CVs just because they updated the class.

@sjiang95
Copy link
Author

Hello @OJFord ,
now the choice is left to users. The default style remains unchanged.

@OJFord
Copy link
Collaborator

OJFord commented Jul 30, 2023

Thanks!

I was thinking though if we did something like:

\newtoggle{showpagetotal}

user can just \toggletrue{showpagetotal} if they want it. Bit easier than toggling comments, and keeps it encapsulated behind \thepage?

Signed-off-by: Shengjiang Quan <qsj287068067@126.com>
@sjiang95
Copy link
Author

sjiang95 commented Jul 30, 2023

@OJFord The toggle is added. Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Extra Small size issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants