Clean up home key in MRP implementation. #696
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HID key the Remote app sends for home and home_hold is different than what is used in the MRP implementation here. Functionality remains the same here.
|
Looks good! You need to make the corresponding update to the MRP service in the fake device since the tests fails. I would also like it if you make it a bit more clear in the commit message what you changed, I usually look at them when writing the change log so it helps a lot. If possible, I try to prefix with a submodule name or something to easier group changes, e.g. "mrp: Correct home button HID code" or something. |
|
Just wanted to see if you want to finish off this PR or if I should take over and get it done? |
|
Now I'm starting to wonder that is correct once again regarding this... At the moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HID key the Remote app sends for
homeandhome_holdis different than what is used in the MRP implementation here. Functionality remains the same just updating to send the same key the Remote app does.