Substitute OpenBeans for java.beans so Android tests work #1067
Conversation
The Android implementation of java.beans does not include everything
which gives rise to error messages like this:
E/TestRunner: java.lang.NoClassDefFoundError: Failed resolution of: Ljava/beans/Introspector; at
org.powermock.configuration.support.ConfigurationMapper.map(ConfigurationMapper.java:44) at
org.powermock.configuration.support.ConfigurationBuilder$ConfigurationCreator.mapConfiguration(ConfigurationBuilder.java:80) at
...
While it's not clear to me why such abject fanciness is needed in the
ConfigurationMapper to take care of a sum total of three properties,
it is clear that this change represents a minimum of source changes to
get to a working state.
Fixes powermock#1062
There was a problem hiding this comment.
I think that better approach is to rewrite ConfigurationMapper in a way that compatable both OpenJDK(Oracle Java) and Google Android JDK I don't know if Google Android JDK supports MethodHandlers but if it does support then MethodHandlers is a good candidate to use here.
| @@ -1 +1,3 @@ | |||
|
|
|||
| dependencies { | |||
| compile("com.musala.atmosphere:openbeans-jxpath:0.0.1") | |||
There was a problem hiding this comment.
As I can see the library is not being developed since 2016. Adding it as dependecies will bring it to all users of PowerMock but fix is needed only for Android users.
I think that better approach is to rewrite ConfigurationMapper in a way that compatable both OpenJDK(Oracle Java) and Google Android Java.
There was a problem hiding this comment.
Sounds like a perfectly valid approach. Let me know if you'd like me to review your PR for it.
|
Is there a chance to give this change a 'critical' priority? Thanks. |
The Android implementation of java.beans does not include everything which gives rise to error messages like this:
While it's not clear to me why such abject fanciness is needed in the ConfigurationMapper to take care of a sum total of three properties, it is clear that this change represents a minimum of source changes to get to a working state on Android.
Fixes #1062