Treat misses and sliderbreaks equally in accuracy for osu! difficulty calculations #27690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes sliderbreaks and misses equal
Finadoggie
changed the title
Finadoggie
changed the title
frenzibyte
changed the title
Someone brought this up during discussion, and from what I can tell, there's no real reason why this wasn't done either. All this does is use the number of circles instead of the number of objects for accuracy calculations, since circles are the only objects that check for accuracy. Could also be merged with ppy#27063 to use circles + sliders when sliders check for accuracy (aka when classic mod is disabled). Currently the code for that is included but commented out.
|
!diffcalc |
|
It appears I did not account for slider-only maps… |
This reverts commit 65e125f.
|
might revisit that later, for now I'm just gonna keep this commit to be just the thing that hopefully works |
|
!diffcalc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, misses and sliderbreaks are generally treated as the same in pp, but misses drop accuracy slightly more than sliderbreaks, leading to misses being slightly more punishing for no real reason. By treating misses as 100s, misses and sliderbreaks will be treated the same in terms of accuracy.
Misses will still be significantly more punishing than 100s or 50s on circles and spinners for obvious reason, this only affects the relation between misses and sliderbreaks
(this makes very little difference on master currently, really only affecting high misscount plays, and matters more for any future PRs which aim to shake up how misses and combo are handled)