Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to allow hiding all country flags #28144

Merged
merged 3 commits into from May 13, 2024

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented May 10, 2024

There have been enough requests for this at this point to implement it.

Required for some countries which have outlawed displaying some flags.

There have been enough requests for this at this point to implement it.
@bdach
Copy link
Collaborator

bdach commented May 10, 2024

I guess the implementation works, but there is a weird quirk in UpdateableFlag that isn't making much sense to me:

/// <summary>
/// Whether to show a place holder on unknown country.
/// </summary>
public bool ShowPlaceholderOnUnknown = true;

Like... why is this configurable? It leads to this silliness:

flags off flags on
local leaderboard osu_2024-05-10_16-30-30 osu_2024-05-10_16-30-26
user profile osu_2024-05-10_16-30-19 osu_2024-05-10_16-30-11

wherein you get "?" in some places and just blank space in others...?

Like I don't get it why "?" is fine in some of these usages and some not and it creates this weird UI inconsistency. I'd probably just nuke that property?

@peppy
Copy link
Sponsor Member Author

peppy commented May 10, 2024

Yeah I did wonder about that. I think always showing the "?" makes more sense right? Rather than an empty space.

@bdach bdach merged commit 87f2a23 into ppy:master May 13, 2024
13 of 17 checks passed
@peppy peppy deleted the hide-country-flags branch May 23, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants