-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 6416: Health Check Additions #6468
base: master
Are you sure you want to change the base?
Issue 6416: Health Check Additions #6468
Conversation
Signed-off-by: anirudhkovuru <anirudhkovuru@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #6468 +/- ##
=========================================
Coverage 86.22% 86.23%
- Complexity 15448 15455 +7
=========================================
Files 1009 1014 +5
Lines 57926 57999 +73
Branches 5914 5913 -1
=========================================
+ Hits 49949 50017 +68
- Misses 4894 4896 +2
- Partials 3083 3086 +3
Continue to review full report at Codecov.
|
@anirudhkovuru I think that there are comments of mine in #6430 that are unaddressed. If you want to continue with this PR, I recommend you to revisit the comments of that PR to see what were the comments and what is left to address before doing another round of review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There may be comments unaddressed from last review in original PR.
Change log description
This is a continuation of #6430.
Purpose of the change
Fixes #6416.
What the code does
This can be found in #6430. Any updates to the existing design will be duly updated.
How to verify it
All tests must pass.