-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 6905: LTS - Correctly pass executor to CompletableFuture Async calls. #6906
base: master
Are you sure you want to change the base?
Issue 6905: LTS - Correctly pass executor to CompletableFuture Async calls. #6906
Conversation
…calls. Signed-off-by: Sachin Joshi <sachin.joshi@emc.com>
Codecov ReportBase: 86.34% // Head: 86.33% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #6906 +/- ##
============================================
- Coverage 86.34% 86.33% -0.01%
+ Complexity 15917 15910 -7
============================================
Files 1027 1027
Lines 59330 59273 -57
Branches 6001 5997 -4
============================================
- Hits 51231 51176 -55
- Misses 4958 4959 +1
+ Partials 3141 3138 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but the coverage check is failing.
Signed-off-by: Sachin Joshi sachin.joshi@emc.com
Change log description
Issue 6905: LTS - Correctly pass executor to CompletableFuture.composeAsync calls.
Purpose of the change
Fixes #6905
What the code does
Correctly pass executor to CompletableFuture.composeAsync calls.
How to verify it
All tests should pass