Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 6961: SLTS - Use more hierarchical organization of chunks. #6962

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Issue 6961: SLTS - Use more hierarchical organization of chunks. #6962

wants to merge 2 commits into from

Conversation

sachin-j-joshi
Copy link
Contributor

@sachin-j-joshi sachin-j-joshi commented Nov 29, 2022 •
edited

Signed-off-by: Sachin Joshi sachin.joshi@emc.com

Change log description
LTS - Use more hierarchical organization where each segment has its own directory with only its own chunks in it.

Purpose of the change
Fixes #6961

What the code does

  • Use more hierarchical organization where each segment has its own directory with only its own chunks in it.
  • For backward compatibility purposes, the new naming scheme is applied only for new chunks after this version. Eventually old chunks with old naming scheme will be deleted. SLTS code stores full path in metadata and therefore it should have no problem accessing and using old chunks. Obviously, there is no backward compatibility problem with fresh deployments.
  • out of scope - This change does NOT change naming scheme for journals.

How to verify it
All tests should pass.
Upgrade should pass.

@sachin-j-joshi
Issue 6961: SLTS - Use more hierarchical organization of chunks
188ef8e 
Signed-off-by: Sachin Joshi <sachin.joshi@emc.com>
@sachin-j-joshi sachin-j-joshi self-assigned this Nov 29, 2022
@sachin-j-joshi
Copy link
Contributor Author

@Amit-Singh40 @AJadhav29 FYI

@sachin-j-joshi sachin-j-joshi marked this pull request as draft November 29, 2022 19:57
Amit-Singh40
Amit-Singh40 approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@Amit-Singh40 Amit-Singh40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amit-Singh40 Amit-Singh40 Amit-Singh40 approved these changes

@abhinb abhinb Awaiting requested review from abhinb

@RaulGracia RaulGracia Awaiting requested review from RaulGracia

At least 1 approving review is required to merge this pull request.

Assignees

@sachin-j-joshi sachin-j-joshi

Labels
area/lts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LTS - Use more hierarchical organization of chunks
2 participants
@sachin-j-joshi @Amit-Singh40