Issue 5008 sporadic failures due used tcp ports #7008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in use Signed-off-by: Kuldeep Kumar <kuldeep.kumar3@dell.com>
Signed-off-by: Kuldeep Kumar <kuldeep.kumar3@dell.com>
Signed-off-by: Kuldeep Kumar <kuldeep.kumar3@dell.com>
Signed-off-by: Kuldeep Kumar <kuldeep.kumar3@dell.com>
abhinb
reviewed
Mar 6, 2023
...l/src/main/java/io/pravega/segmentstore/storage/impl/bookkeeper/BookKeeperServiceRunner.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/io/pravega/segmentstore/storage/impl/bookkeeper/BookKeeperServiceRunner.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/io/pravega/segmentstore/storage/impl/bookkeeper/BookKeeperServiceRunner.java
Outdated
Show resolved
Hide resolved
|
Could you test this by checking if you can make the test start on a already occupied port and then see if the retry logic works? |
Bhupender-Y
reviewed
Mar 7, 2023
...l/src/main/java/io/pravega/segmentstore/storage/impl/bookkeeper/BookKeeperServiceRunner.java
Show resolved
Hide resolved
...l/src/main/java/io/pravega/segmentstore/storage/impl/bookkeeper/BookKeeperServiceRunner.java
Outdated
Show resolved
Hide resolved
tkaitchuck
reviewed
Mar 8, 2023
...l/src/main/java/io/pravega/segmentstore/storage/impl/bookkeeper/BookKeeperServiceRunner.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/io/pravega/segmentstore/storage/impl/bookkeeper/BookKeeperServiceRunner.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/io/pravega/segmentstore/storage/impl/bookkeeper/BookKeeperServiceRunner.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/io/pravega/segmentstore/storage/impl/bookkeeper/BookKeeperServiceRunner.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/io/pravega/segmentstore/storage/impl/bookkeeper/BookKeeperServiceRunner.java
Outdated
Show resolved
Hide resolved
shshashwat
reviewed
Mar 9, 2023
...l/src/main/java/io/pravega/segmentstore/storage/impl/bookkeeper/BookKeeperServiceRunner.java
Show resolved
Hide resolved
Signed-off-by: Kuldeep Kumar <kuldeep.kumar3@dell.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7008 +/- ##
============================================
- Coverage 86.33% 86.32% -0.01%
+ Complexity 16048 16002 -46
============================================
Files 1031 1030 -1
Lines 59815 59543 -272
Branches 6071 6024 -47
============================================
- Hits 51639 51402 -237
+ Misses 4998 4991 -7
+ Partials 3178 3150 -28
... and 29 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
RaulGracia
requested changes
Mar 13, 2023
| bookieServerAndResources = runBookie(bkPort); | ||
| retry = false; | ||
| } catch (BindException e) { | ||
| if ( ++count >= retries ) { |
There was a problem hiding this comment.
Remove extra head and tail spaces.
...l/src/main/java/io/pravega/segmentstore/storage/impl/bookkeeper/BookKeeperServiceRunner.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/io/pravega/segmentstore/storage/impl/bookkeeper/BookKeeperServiceRunner.java
Show resolved
Hide resolved
...l/src/main/java/io/pravega/segmentstore/storage/impl/bookkeeper/BookKeeperServiceRunner.java
Show resolved
Hide resolved
…t/common/TestUtils.java -> common/src/main/java/io/pravega/common/util/CommonUtils.java Signed-off-by: Kuldeep Kumar <kuldeep.kumar3@dell.com>
…ps://github.com/kuldeepk3/pravega into issue-5008-sporadic-failures-due-used-tcp-ports
Signed-off-by: Kuldeep Kumar <kuldeep.kumar3@dell.com>
Signed-off-by: Kuldeep Kumar <kuldeep.kumar3@dell.com>
Signed-off-by: Kuldeep Kumar <kuldeep.kumar3@dell.com>
Signed-off-by: Kuldeep Kumar <kuldeep.kumar3@dell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
This pr addresses
Sporadic failures due used tcp portsin case there is failure while starting bookeeper and goes for a retry.Purpose of the change
Fixes #5008
What the code does
Adding retry in case bookkeeper fails to start with
address already in use. This change will retry the creation of bookkeeper in case it fails to start withBindException.How to verify it
Execute the unit test and there should be no failure with exception:
java.net.BindException: Address already in use