Issue 7166: Fixing durable log inspect command to give correct result #7171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kuldeep Kumar <Kuldeep.kumar3@dell.com>
kuldeepk3
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7171 +/- ##
============================================
- Coverage 86.40% 86.37% -0.04%
- Complexity 16106 16174 +68
============================================
Files 1034 1034
Lines 59991 60057 +66
Branches 6107 6132 +25
============================================
+ Hits 51836 51875 +39
- Misses 4979 4992 +13
- Partials 3176 3190 +14
☔ View full report in Codecov by Sentry. |
Signed-off-by: Kuldeep Kumar <Kuldeep.kumar3@dell.com>
Signed-off-by: Kuldeep Kumar <Kuldeep.kumar3@dell.com>
Signed-off-by: Kuldeep Kumar <Kuldeep.kumar3@dell.com>
tkaitchuck
requested changes
Jan 3, 2024
| if (conditionTpe.equals(ATTRIBUTES)) { | ||
| predicates.add(a -> a.getAttributes() == in); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
If something other than "value" is used they will get "range". This is a serious problem if someone for example types "Value" or "value ".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Updating DurableLogInspectCommand to return correct result when inspecting for Length, Offset, Attributes using either value or range.
Purpose of the change
Fixes #7166
What the code does
Adding code to evaluate condition when Length, Offset , Attributes are given.
How to verify it
Open admin cli and run durable log inspect command