Issue 7179: Adding integration tests for recovery from lts #7175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kuldeep Kumar <Kuldeep.kumar3@dell.com>
Signed-off-by: Kuldeep Kumar <Kuldeep.kumar3@dell.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feature_ltsrecovery #7175 +/- ##
======================================================
Coverage ? 86.19%
Complexity ? 16130
======================================================
Files ? 1035
Lines ? 60201
Branches ? 6114
======================================================
Hits ? 51892
Misses ? 5115
Partials ? 3194 ☔ View full report in Codecov by Sentry. |
test/integration/src/test/java/io/pravega/test/integration/BackUpRecoveryTest.java
Outdated
Show resolved
Hide resolved
test/integration/src/test/java/io/pravega/test/integration/BackUpRecoveryTest.java
Outdated
Show resolved
Hide resolved
test/integration/src/test/java/io/pravega/test/integration/BackUpRecoveryTest.java
Outdated
Show resolved
Hide resolved
test/integration/src/test/java/io/pravega/test/integration/BackUpRecoveryTest.java
Show resolved
Hide resolved
test/integration/src/test/java/io/pravega/test/integration/BackUpRecoveryTest.java
Outdated
Show resolved
Hide resolved
test/integration/src/test/java/io/pravega/test/integration/BackUpRecoveryTest.java
Show resolved
Hide resolved
test/integration/src/test/java/io/pravega/test/integration/BackUpRecoveryTest.java
Outdated
Show resolved
Hide resolved
| readEventsFromStream(clientRunner.clientFactory, clientRunner.readerGroupManager); | ||
| log.info("Read all events again to verify that segments were recovered."); | ||
| } | ||
| FileUtils.deleteDirectory(new File(baseDir.getPath())); |
There was a problem hiding this comment.
what if exception is thrown?
| log.info("Started segment store and controller again."); | ||
|
|
||
| log.info("Starting client to read Events "); | ||
| // Create the client with new controller. |
There was a problem hiding this comment.
Seems like there is opportunity to refactor common code.
test/integration/src/test/java/io/pravega/test/integration/BackUpRecoveryTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kuldeep Kumar <Kuldeep.kumar3@dell.com>
abhinb
reviewed
Aug 9, 2023
test/integration/src/test/java/io/pravega/test/integration/BackUpRecoveryTest.java
Outdated
Show resolved
Hide resolved
test/integration/src/test/java/io/pravega/test/integration/BackUpRecoveryTest.java
Outdated
Show resolved
Hide resolved
test/integration/src/test/java/io/pravega/test/integration/BackUpRecoveryTest.java
Outdated
Show resolved
Hide resolved
test/integration/src/test/java/io/pravega/test/integration/BackUpRecoveryTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kuldeep Kumar <Kuldeep.kumar3@dell.com>
Signed-off-by: Kuldeep Kumar <Kuldeep.kumar3@dell.com>
RaulGracia
changed the title
tkaitchuck
requested changes
Jan 3, 2024
|
|
||
| private FileSystemSimpleStorageFactory storageFactory; | ||
|
|
||
| private BookKeeperLogFactory dataLogFactory; |
There was a problem hiding this comment.
This appears to be initialized by each test individually. It can be made into a local.
|
|
||
| @Override | ||
| protected int getThreadPoolSize() { | ||
| return 100; |
| * 7. Reads all events. | ||
| * @throws Exception In case of an exception occurred while execution. | ||
| */ | ||
| @Test(timeout = 180000) |
There was a problem hiding this comment.
Here and elsewhere in this file:
This is going to run on every single checkin. Right now we run 1000+ tests in ~20 minutes. If these are taking anywhere near three minutes each, they need to be speed up.
| pravegaRunner.close(); | ||
| log.info("SegmentStore, BookKeeper & ZooKeeper shutdown"); | ||
|
|
||
| Thread.sleep(1000); |
There was a problem hiding this comment.
Sleeping is not allowed in unit tests.
| pravegaRunner.close(); | ||
| log.info("SegmentStore, BookKeeper & ZooKeeper shutdown"); | ||
|
|
||
| Thread.sleep(1000); |
There was a problem hiding this comment.
Sleeping is not allowed in unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kuldeep Kumar Kuldeep.kumar3@dell.com
Change log description
Adding integration tests for recovery from lts
Purpose of the change
Fixes #7179
What the code does
Adds integration tests
How to verify it
NA