Parallelize deletion of zk garbage #7415
Conversation
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
| zclient.delete().idempotent().deletingChildrenIfNeeded().inBackground(new BackgroundCallback() { | ||
| @Override | ||
| public void processResult(CuratorFramework client, CuratorEvent event) throws Exception { | ||
| future.complete(path); |
There was a problem hiding this comment.
Aren't we handling errors?
Is it possible that the CF is never completed neither successfully nor exceptionally?
| public void processResult(CuratorFramework client, CuratorEvent event) throws Exception { | ||
| future.complete(path); | ||
| } | ||
| }).forPath(path); | ||
| } catch (Exception e) { | ||
| log.warn("Not able to delete path {} . Exception {}", path, e.getMessage()); | ||
| } | ||
| } |
There was a problem hiding this comment.
What about setting a timeout?
|
@tkaitchuck maybe you have tried this already, but when executed in isolation, the test passes: Probably you know that already, but the fact that this test is being executed in parallel with other "standalone" tests may be a potential source of failure (but I don't have a root cause for this yet). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7415 +/- ##
=========================================
Coverage 86.07% 86.08%
Complexity 16476 16476
=========================================
Files 1048 1048
Lines 61490 61490
Branches 6220 6220
=========================================
+ Hits 52930 52932 +2
+ Misses 5347 5340 -7
- Partials 3213 3218 +5 ☔ View full report in Codecov by Sentry. |
|
@RaulGracia Note the My current theory is that there is test which runs before it causing problems. |
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Change log description
Attempt at fixing: InProcPravegaClusterTest
https://github.com/pravega/pravega/actions/runs/7933776118/job/21778295050?pr=7396
Purpose of the change
What the code does