Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marlin #189

Closed
wants to merge 15 commits into from
Closed

marlin #189

wants to merge 15 commits into from

Conversation

flozi00
Copy link
Collaborator

@flozi00 flozi00 commented Jan 18, 2024

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Was this discussed/approved via a Github issue or the discord / slack channel? Please add a link
    to it if that's the case.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@flozi00 flozi00 linked an issue Jan 18, 2024 that may be closed by this pull request
@flozi00
Copy link
Collaborator Author

flozi00 commented Jan 19, 2024

Looks like I need help at debugging @tgaddair
The kernel is incompatible with the flash attention kernels
Illegal Memory access error occures every time

docker run --pull always -v ./data:/data --gpus all -d --shm-size 1g -p 8080:80 ghcr.io/predibase/lorax:marlin --model-id TheBloke/dolphin-2.6-mistral-7B-dpo-GPTQ --quantize marlin

@flozi00 flozi00 marked this pull request as draft January 19, 2024 16:24
@flozi00
Copy link
Collaborator Author

flozi00 commented Jan 23, 2024

@tgaddair on the disco research server i read an comment about the incompitability with fused attention
Don't have any idea if they want to support it in future or not.

I think without flash attention this feature would not makes much sense because of the much higher memory requirements for longer sequences.

Will keep this PR as draft until it's compatible but won't work actively on it

@tgaddair
Copy link
Contributor

Thanks @flozi00 , we can hold off until that's supported then.

@flozi00 flozi00 closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

marlin
2 participants